Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change deployment liveness probe settings #98

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

RMcVelia
Copy link
Contributor

@RMcVelia RMcVelia commented Jun 3, 2024

Context

https://trello.com/c/p9TYi8Rp/1850-decrease-container-liveness-probes

Application deployment Liveness probe settings need tuning
Current setting generates a lot of probe activity and log entries per container.

Changes proposed in this pull request

Old settings

  • failure_threshold = 10, period_seconds = 1, timeout_seconds = 10
  • i.e. 1 probe per second, 10 consecutive failures (9s after first failure) trigger container replacement, 10s timeout

New settings

  • failure_threshold = 5, period_seconds = 5, timeout_seconds = 5
  • i.e. 1 probe per 5 seconds, 5 consecutive failures (20s after first failure) trigger container replacement, 5s timeout

Guidance to review

deploy-plan from a service pointed to this branch

Checklist

  • I have performed a self-review of my code, including formatting and typos
  • I have cleaned the commit history
  • I have added the Devops label
  • I have attached the pull request to the trello card

@RMcVelia
Copy link
Contributor Author

RMcVelia commented Jun 3, 2024

@RMcVelia RMcVelia merged commit 140eac1 into main Jun 3, 2024
3 checks passed
@RMcVelia RMcVelia deleted the 1850-decrease-container-liveness-probes branch June 3, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants